fix: Property saving and synchronization improvements#529
Open
hypnosis wants to merge 2 commits intoMake-md:mainfrom
Open
fix: Property saving and synchronization improvements#529hypnosis wants to merge 2 commits intoMake-md:mainfrom
hypnosis wants to merge 2 commits intoMake-md:mainfrom
Conversation
added 2 commits
January 14, 2026 20:48
Fixes issue where editing options in table properties would not save correctly. Changes: - Fix PropertyValue.tsx: Save options and colorScheme atomically to prevent data loss - Fix EditOptionsModal.tsx: Auto-close color picker menu after color selection - Fix OptionCell.tsx: Prioritize individual option colors over color scheme - Fix package.json: Correct typo in dev script (nnode -> node) - Update tsconfig.json: Change target from es6 to es2020 to support regex dotall flag - Update .gitignore: Add data.json to ignore user settings The main issue was that calling saveParsedValue twice would overwrite the first save with stale data. Now both fields are saved in a single atomic operation.
Fixed issue where checkbox properties in the top section (inline properties) were not updating when changed in the bottom Properties section. Root cause: PropertiesView component was only listening to 'contextStateUpdated' events, which are not triggered when individual file properties are saved via saveProperties(). When a checkbox is toggled, it saves via saveProperties() which triggers 'pathStateUpdated' event instead. Solution: Added listener for 'pathStateUpdated' event to refresh property values when the current path's properties change. This ensures both property sections stay in sync. Changes: - Added pathChanged() handler to listen for pathStateUpdated events - Added pathState to useEffect dependencies for proper cleanup - Properties now refresh immediately when any property is saved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed multiple issues with property saving and synchronization in the Make.md plugin:
Issues Fixed
Changes
1. Atomic saving of options and color schemes (
PropertyValue.tsx)saveOptionsHandlerto perform atomic update of bothoptionsandcolorScheme2. Color priority fix (
OptionCell.tsx)3. Auto-close color picker (
EditOptionsModal.tsx)hidecallback toshowColorPickerMenu4. Property synchronization (
PropertiesView.tsx)pathStateUpdatedevent5. Build improvements
es2020for consistency with esbuildpackage.jsondev scriptdata.jsonto.gitignoreTesting
Compatibility
es2020(aligns with esbuild config)